[Lldb-commits] [PATCH] D74388: [lldb/test] Add alternate symbol to StackFrame Recognizer

Tue Feb 11 02:22:46 PST 2020

jankratochvil accepted this revision.
jankratochvil added a comment.
This revision is now accepted and ready to land.

> This patch reverts commit 6b2979c12300b90a1e69791d43ee9cff14f4265e <https://reviews.llvm.org/rG6b2979c12300b90a1e69791d43ee9cff14f4265e>

The patch is already reverted, this patch reimplements it.

In D74388#1868935 <https://reviews.llvm.org/D74388#1868935>, @mib wrote:

> Could you let me know if this works on your end ?

Yes, it works on Fedora 31 x86_64.

================
Comment at: lldb/source/Target/AssertFrameRecognizer.cpp:144
+        (!location.alternate_symbol_name.IsEmpty() &&
+         func_name == location.alternate_symbol_name)) {

----------------
I see I made a mistake here, thanks for fixing it. That was probably the OSX regression.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74388/new/

https://reviews.llvm.org/D74388