[Lldb-commits] [PATCH] D74168: [CMake] Make EXCLUDE_FROM_ALL an argument to add_lit_testsuite

Fri Feb 7 15:20:06 PST 2020

JDevlieghere marked an inline comment as done.
JDevlieghere added inline comments.

================
Comment at: llvm/test/CMakeLists.txt:171

+if(LLVM_BUILD_TOOLS)
+  set(exclude_from_check_all "EXCLUDE_FROM_CHECK_ALL")
----------------
JDevlieghere wrote:
> kschwarz wrote:
> > Hi @JDevlieghere, we've noticed that with this patch check-llvm isn't added to check-all anymore by default. Is this the intended behaviour?
> Nope, I unintentionally inverted the condition. Thanks for pointing this out! 
Fixed in `c10b9f0bde2666abd3e2d0845dee16ac9db1ab6f`

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74168/new/

https://reviews.llvm.org/D74168