[Lldb-commits] [PATCH] D74252: Fix+re-enable Assert StackFrame Recognizer on Linux

[Med Ismail Bennani via Phabricator via lldb-commits]

mib added a comment.

In D74252#1865501 <https://reviews.llvm.org/D74252#1865501>, @jankratochvil wrote:

> In D74252#1865500 <https://reviews.llvm.org/D74252#1865500>, @mib wrote:
>
> > Knowing that this will be called every time a thread stops, it would be better if we could avoid processing a regex every time we try to recognise a frame.
>
>
> Or `StackFrameRecognizerManagerImpl::AddRecognizer` and its `m_recognizers` can have `ConstString symbol1, symbol2;`. What is less bad?


This sounds like a good idea, but let's leave symbol as is and add a `ConstString alternate_symbol` defaulting to an empty `ConstString`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74252/new/

https://reviews.llvm.org/D74252