[Lldb-commits] [PATCH] D74252: Fix+re-enable Assert StackFrame Recognizer

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil added a comment.

I have reverted this change as it fixed the testsuite but real world usage was broken:

  (lldb) run
  assert.test.tmp.out: /home/jkratoch/redhat/llvm-monorepo/lldb/test/Shell/Recognizer/Inputs/assert.c:7: int main(): Assertion `a == 42' failed.
  Process 12062 stopped
  * thread #1, name = 'assert.test.tmp', stop reason = signal SIGABRT
      frame #0: 0x00007ffff7ddee35 libc.so.6`__GI_raise(sig=2) at raise.c:51:1
     48     __libc_signal_restore_set (&set);
     49
     50     return ret;
  -> 51   }
     52   libc_hidden_def (raise)
     53   weak_alias (raise, gsignal)

I think it really needs to compare both variants of the function name on Linux.
Both variants get mapped name->address but it is difficult to say which one will get looked up address->name.
Otherwise one could also fix why DWARF resolves the __GI_* variants from:

  <4d4b>   DW_AT_linkage_name: (indirect string, offset: 0x1b784): __GI___assert_fail
  <4d4f>   DW_AT_name        : (indirect string, offset: 0x1b789): __assert_fail


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74252/new/

https://reviews.llvm.org/D74252