[Lldb-commits] [PATCH] D74245: [lldb/Plugins] Use external functions to (de)initialize plugins

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere created this revision.
JDevlieghere added reviewers: labath, xiaobai.
Herald added subscribers: lldb-commits, abidh.
Herald added a project: LLDB.

This is a step towards making the initialize and terminate calls be generated by CMake, which in turn is towards making it possible to disable plugins at configuration time.

The other alternative discussed was static initializers, but that requires a non-portable linker flag that will prevent the linker from performing dead code elimination.

For this path I just did the ScriptInterpreter plugins. If everyone is on board with the approach I plan to land this in two patches, one with the macros as shown here and another patch where CMake generates the macro expansion for us.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D74245

Files:
  lldb/include/lldb/Core/PluginManager.h
  lldb/source/API/SystemInitializerFull.cpp
  lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.cpp
  lldb/source/Plugins/ScriptInterpreter/None/ScriptInterpreterNone.cpp
  lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74245.243247.patch
Type: text/x-patch
Size: 5708 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200207/d671fac5/attachment.bin>