[Lldb-commits] [PATCH] D74212: [lldb/Target] Fix `frame recognizer list` crash when registered with nullptr

[Frederic Riss via Phabricator via lldb-commits]

friss accepted this revision.
friss added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lldb/unittests/Target/StackFrameRecognizerTest.cpp:83-87
+        if (name == "")
+          name = "(internal)";
+        stream_sp->Printf("%d: %s, module %s, function %s%s\n", recognizer_id,
+                          name.c_str(), function.c_str(), symbol.c_str(),
+                          regexp ? " (regexp)" : "");
----------------
Either check what's printed to the stream or just check the boolean, but there's no reason to add the printing logic if the result is not used.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74212/new/

https://reviews.llvm.org/D74212