[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

[Jaroslav Sevcik via Phabricator via lldb-commits]

jarin added inline comments.


================
Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:2819
+    response.Printf("<feature>");
+    const int registersCount = 128;
+    for (int reg_index = 0; reg_index < registersCount; reg_index++) {
----------------
As discussed offline, this should not be hard-coded, register context provides register count.


================
Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:2825
+      response.Printf(
+          "<reg name=\"%s\" bitsize=\"%u\" offset=\"%u\" regnum=\"%d\" />",
+          reg_info->name, reg_info->byte_size * 8, reg_info->byte_offset,
----------------
Fill all the relevant fields, please (everything that the qRegisterInfo handler provides).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74217/new/

https://reviews.llvm.org/D74217