[Lldb-commits] [PATCH] D74187: [lldb] Add method Language::IsMangledName

[Alex Langford via Phabricator via lldb-commits]

xiaobai added inline comments.


================
Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.h:96-98
+  bool IsMangledName(llvm::StringRef name) const override {
+    return false;
+  }
----------------
friss wrote:
> The original code was calling `IsPossibleObjCMethodName` and it looks like you completely lose this codepath with this rewrite. Unclear to me if it's the right thing to return here, but that's definitely a change in behavior.
If I understand correctly, Objective-C names aren't mangled in general, and are usually stored in the `m_demangled` name of `Mangled`, so that code path should have been bogus to begin with. Maybe I'm missing a detail though?

I can add a comment to this to clarify that Objective-C names aren't mangled (if I am correct in my understanding).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74187/new/

https://reviews.llvm.org/D74187