[Lldb-commits] [PATCH] D74153: [lldb] Delete the SharingPtr class

Thu Feb 6 17:02:32 PST 2020

jingham added a comment.

In D74153#1862554 <https://reviews.llvm.org/D74153#1862554>, @labath wrote:

> Actually, it looks like we were getting away with that because the whole ValueObjectRegisterContext (*not* RegisterSet) class is unused. In fact the whole concept of having the entire register context as a "value" seems fairly odd to me. Can we just delete it?

Oh, interesting.  I have no idea what that is for.  Looks like it was part of the initial checkin of lldb -> llvm.org, and except for formal changes hasn't actually been touched since then.  Seems like if we haven't used it by now, it's fine to get rid of it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74153/new/

https://reviews.llvm.org/D74153