[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Assert StackFrame Recognizer

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil added a comment.

Even with the latest variant (commit `7ebe9cc4fc2d97ec0ed2a6038be25b2a7ed1aac2`) I am getting on Fedora 30 x86_64:

  /home/jkratoch/redhat/llvm-monorepo/lldb/test/Shell/Recognizer/assert.test:5:10: error: CHECK: expected string not found in input
  # CHECK: thread #{{.*}}stop reason = hit program assert
           ^
  <stdin>:1:1: note: scanning from here
  (lldb) command source -s 0 '/home/jkratoch/redhat/llvm-monorepo-clangassert/tools/lldb/test/Shell/lit-lldb-init'
  ^
  <stdin>:15:34: note: possible intended match here
  * thread #1, name = 'assert.test.tmp', stop reason = signal SIGABRT
                                   ^

The output is:

  (lldb) command source -s 0 '/home/jkratoch/redhat/llvm-monorepo/lldb/test/Shell/Recognizer/assert.test'
  Executing commands in '/home/jkratoch/redhat/llvm-monorepo/lldb/test/Shell/Recognizer/assert.test'.
  (lldb) run
  assert.test.tmp.out: /home/jkratoch/redhat/llvm-monorepo/lldb/test/Shell/Recognizer/Inputs/assert.c:7: int main(): Assertion `a == 42' failed.
  Process 29077 stopped
  * thread #1, name = 'assert.test.tmp', stop reason = signal SIGABRT
      frame #0: 0x00007ffff7ddee35 libc.so.6`raise + 325
  libc.so.6`raise:
  ->  0x7ffff7ddee35 <+325>: movq   0x108(%rsp), %rax
      0x7ffff7ddee3d <+333>: xorq   %fs:0x28, %rax
      0x7ffff7ddee46 <+342>: jne    0x7ffff7ddee6c            ; <+380>
      0x7ffff7ddee48 <+344>: movl   %r8d, %eax
  
  Process 29077 launched: '/home/jkratoch/redhat/llvm-monorepo-clangassert/tools/lldb/test/Recognizer/Output/assert.test.tmp.out' (x86_64)
  (lldb) frame info
  frame #0: 0x00007ffff7ddee35 libc.so.6`raise + 325
  (lldb) frame recognizer info 0
  frame 0 is recognized by Assert StackFrame Recognizer
  (lldb) set set thread-format "{${thread.stop-reason-raw}}\n"
  (lldb) thread info
  signal SIGABRT
  
  (lldb) q

Visible also on (silent) Fedora buildbot <http://lab.llvm.org:8014/builders/lldb-x86_64-fedora?numbuilds=1000>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73303/new/

https://reviews.llvm.org/D73303