[Lldb-commits] [PATCH] D74153: [lldb] Delete the SharingPtr class

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

I think the ValueObjectRegisterSet::CreateChildAtIndex was wrong originally.  It doesn't make it's children by passing itself in as the parent of the child, but just makes an independent ValueObject.  You can fix that in your version by passing the ValueObjectRegisterSet's manager.



================
Comment at: lldb/source/Core/ValueObjectRegister.cpp:96
     ExecutionContext exe_ctx(GetExecutionContextRef());
+    auto manager_sp = ValueObjectManager::Create();
     new_valobj = new ValueObjectRegisterSet(
----------------
Is this right?  You are making a child of the ValueObjectRegisterContext, so it should  use the manager of its parent, shouldn't it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74153/new/

https://reviews.llvm.org/D74153