[Lldb-commits] [PATCH] D74148: [lldb\utils] Place lldb-repro in a per-configuration directory to support multi-configuration generators

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 6 11:17:17 PST 2020


JDevlieghere added inline comments.


================
Comment at: lldb/utils/lldb-repro/CMakeLists.txt:6
+# Generate lldb-repro Python script for each build mode.
+if(LLDB_BUILT_STANDALONE)
+  set(config_types ".")
----------------
Do you think it's possible/worthwhile to factor out this code in a CMake macro/function? We have a few places where we have to do something similar, but it's never exactly the same. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74148/new/

https://reviews.llvm.org/D74148





More information about the lldb-commits mailing list