[Lldb-commits] [PATCH] D73787: [NFC] Refactor `GetDWARFDeclContext` to return `DWARFDeclContext`

Jan Kratochvil via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 6 10:20:59 PST 2020


jankratochvil added a comment.

In D73787#1859754 <https://reviews.llvm.org/D73787#1859754>, @labath wrote:

> One way to this could be improved further is to change the recursion in `GetDWARFDeclContext` into a loop (then you wouldn't need the extra wrapper).


True, I am stupid. But then I find there a need for the static method (as having `this` and iterating `die` pointer is error-prone).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73787/new/

https://reviews.llvm.org/D73787





More information about the lldb-commits mailing list