[Lldb-commits] [PATCH] D73969: [LLDB] Let DataExtractor deal with two-byte addresses

Thu Feb 6 08:34:33 PST 2020

labath added a comment.

In D73969#1861494 <https://reviews.llvm.org/D73969#1861494>, @aykevl wrote:

> >> Right now there are asserts both when constructing/copying(?) the object (5 asserts) and at the place where `m_addr_size` is used (3 asserts). I would propose picking one place, such as where it is used. That would reduce the number of asserts to 3 and keep them close together. What do you think?
> > 
> > I agree only one of those two places should be enough. My idea was to make the constructors delegate to one another (if necessary by creating a private uber-constructor that everybody can delegate to). Then we could have only one assert.
>
> Should I do that in the same patch, or in a different one? Before or after this patch? It seems like doing the constructor merging in this patch would make it more complicated than necessary.

My hope is that this will be a relatively simple thing, in which case it would be ok to put it into this patch. But I am fine with doing it separately as well...

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73969/new/

https://reviews.llvm.org/D73969