[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Assert StackFrame Recognizer

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

It looks like there is still some memory corruption going on:

  lldb) target create --core "../llvm-project/lldb/packages/Python/lldbsuite/test/functionalities/postmortem/minidump/fizzbuzz_no_heap.dmp"
  (lldb) bt
  * thread #1, stop reason = Exception 0xc0000005 encountered at address 0x164d14
    * frame #0: 0x00164d14 fizzbuzz.exe
      frame #1: 0x00167c79 fizzbuzz.exe
     ...
  (lldb) script lldb.thread.GetStopDescription(256)
  '\xf0\xfca\x02'



================
Comment at: lldb/source/Target/AssertFrameRecognizer.cpp:63-65
+    symbol_name = "__GI_raise";
+    if (!ModuleHasDebugInfo(target, module_spec, symbol_name))
+      symbol_name = "raise";
----------------
This part looks pretty kludgy. Maybe the function should just return a list of symbols (and shared libraries) and have this thing be handled at a higher level.

This is going to be needed in order to support other C library implementations (e.g. musl) on linux, and it's not inconceivable that the internal glibc symbol name will change in the future too...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73303/new/

https://reviews.llvm.org/D73303