[Lldb-commits] [lldb] 706256b - [lldb] Revert some change in data-formatter-objc/main.m that broke TestDataFormatterObjCNSDate.py

Raphael Isemann via lldb-commits lldb-commits at lists.llvm.org
Wed Feb 5 05:09:19 PST 2020


Author: Raphael Isemann
Date: 2020-02-05T14:08:57+01:00
New Revision: 706256b6d3972dcfa2d3e888d0640e1689c4be95

URL: https://github.com/llvm/llvm-project/commit/706256b6d3972dcfa2d3e888d0640e1689c4be95
DIFF: https://github.com/llvm/llvm-project/commit/706256b6d3972dcfa2d3e888d0640e1689c4be95.diff

LOG: [lldb] Revert some change in data-formatter-objc/main.m that broke TestDataFormatterObjCNSDate.py

Changing the date2 to an timezone independent value broke the test as the data formatters
uses the current time zone for the summary (so changing it to a time zone independent value
would again break the test in some time zones). We anyway just care about this for date2
which will be printed in a timezone-independent summary.

Added: 
    

Modified: 
    lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-objc/main.m

Removed: 
    


################################################################################
diff  --git a/lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-objc/main.m b/lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-objc/main.m
index 81ac2185314a..d0fa27570973 100644
--- a/lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-objc/main.m
+++ b/lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-objc/main.m
@@ -502,7 +502,7 @@ int main (int argc, const char * argv[])
 	    NSURL *nsurl3 = [NSURL URLWithString:@"?whatever" relativeToURL:nsurl2];
     
 		NSDate *date1 = [NSDate dateWithTimeIntervalSince1970:133890*60*60]; // 6pm April 10, 1985 GMT
-		NSDate *date2 = [NSDate dateWithTimeIntervalSince1970:14975*24*60*60]; // 12am January 1, 2011 GMT
+		NSDate *date2 = [NSDate dateWithNaturalLanguageString:@"12am January 1, 2011"];
 		NSDate *date3 = [NSDate date];
 		NSDate *date4 = [NSDate dateWithTimeIntervalSince1970:24*60*60];
     NSDate *date5 = [NSDate dateWithTimeIntervalSinceReferenceDate: floor([[NSDate date] timeIntervalSinceReferenceDate])];


        


More information about the lldb-commits mailing list