[Lldb-commits] [PATCH] D73969: [LLDB] Let DataExtractor deal with two-byte addresses

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

I think this is a much better approach than the other do-in-all-together patch -- we should take this one step at a time.

I do have one question though. Will the DataExtractor actually do something reasonable for non-power-of-2 sizes (5,6,7) ? If yes, then great -- if not, we should keep the assert as `2 || 4 || 8`.

I agree that more tests would be useful, but I would not consider that as a requirement for this patch. If you want, you can submit extra tests in separate patches.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73969/new/

https://reviews.llvm.org/D73969