[Lldb-commits] [lldb] 48b8e3b - [lldb] Delete commented-out code

Alex Langford via lldb-commits lldb-commits at lists.llvm.org
Tue Feb 4 15:33:17 PST 2020


Author: Alex Langford
Date: 2020-02-04T15:33:06-08:00
New Revision: 48b8e3be51c7fa2bda904bc495af47c7b368e748

URL: https://github.com/llvm/llvm-project/commit/48b8e3be51c7fa2bda904bc495af47c7b368e748
DIFF: https://github.com/llvm/llvm-project/commit/48b8e3be51c7fa2bda904bc495af47c7b368e748.diff

LOG: [lldb] Delete commented-out code

Added: 
    

Modified: 
    lldb/source/Core/ValueObjectCast.cpp
    lldb/source/Core/ValueObjectConstResult.cpp
    lldb/source/Core/ValueObjectDynamicValue.cpp
    lldb/source/Core/ValueObjectMemory.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Core/ValueObjectCast.cpp b/lldb/source/Core/ValueObjectCast.cpp
index 916a66a7ab57..22e856be539b 100644
--- a/lldb/source/Core/ValueObjectCast.cpp
+++ b/lldb/source/Core/ValueObjectCast.cpp
@@ -33,8 +33,6 @@ ValueObjectCast::ValueObjectCast(ValueObject &parent, ConstString name,
                                  const CompilerType &cast_type)
     : ValueObject(parent), m_cast_type(cast_type) {
   SetName(name);
-  // m_value.SetContext (Value::eContextTypeClangType,
-  // cast_type.GetOpaqueQualType());
   m_value.SetCompilerType(cast_type);
 }
 
@@ -68,7 +66,6 @@ bool ValueObjectCast::UpdateValue() {
     m_update_point.SetUpdated();
     m_value = m_parent->GetValue();
     CompilerType compiler_type(GetCompilerType());
-    // m_value.SetContext (Value::eContextTypeClangType, compiler_type);
     m_value.SetCompilerType(compiler_type);
     SetAddressTypeOfChildren(m_parent->GetAddressTypeOfChildren());
     if (!CanProvideValue()) {

diff  --git a/lldb/source/Core/ValueObjectConstResult.cpp b/lldb/source/Core/ValueObjectConstResult.cpp
index 0596415885be..4fe05e0b3333 100644
--- a/lldb/source/Core/ValueObjectConstResult.cpp
+++ b/lldb/source/Core/ValueObjectConstResult.cpp
@@ -110,7 +110,6 @@ ValueObjectConstResult::ValueObjectConstResult(
   m_data.SetData(data_sp);
   m_value.GetScalar() = (uintptr_t)data_sp->GetBytes();
   m_value.SetValueType(Value::eValueTypeHostAddress);
-  // m_value.SetContext(Value::eContextTypeClangType, compiler_type);
   m_value.SetCompilerType(compiler_type);
   m_name = name;
   SetIsConstant();
@@ -153,7 +152,6 @@ ValueObjectConstResult::ValueObjectConstResult(
     m_value.SetValueType(Value::eValueTypeHostAddress);
     break;
   }
-  //    m_value.SetContext(Value::eContextTypeClangType, compiler_type);
   m_value.SetCompilerType(compiler_type);
   m_name = name;
   SetIsConstant();

diff  --git a/lldb/source/Core/ValueObjectDynamicValue.cpp b/lldb/source/Core/ValueObjectDynamicValue.cpp
index a03e55d59334..149984df1841 100644
--- a/lldb/source/Core/ValueObjectDynamicValue.cpp
+++ b/lldb/source/Core/ValueObjectDynamicValue.cpp
@@ -237,7 +237,6 @@ bool ValueObjectDynamicValue::UpdateValue() {
     m_dynamic_type_info =
         runtime->FixUpDynamicType(m_dynamic_type_info, *m_parent);
 
-  // m_value.SetContext (Value::eContextTypeClangType, corrected_type);
   m_value.SetCompilerType(m_dynamic_type_info.GetCompilerType());
 
   m_value.SetValueType(value_type);

diff  --git a/lldb/source/Core/ValueObjectMemory.cpp b/lldb/source/Core/ValueObjectMemory.cpp
index 417bcd666cd6..b7559bfe5fd2 100644
--- a/lldb/source/Core/ValueObjectMemory.cpp
+++ b/lldb/source/Core/ValueObjectMemory.cpp
@@ -82,8 +82,6 @@ ValueObjectMemory::ValueObjectMemory(ExecutionContextScope *exe_scope,
   TargetSP target_sp(GetTargetSP());
 
   SetName(ConstString(name));
-  //    m_value.SetContext(Value::eContextTypeClangType,
-  //    m_compiler_type.GetOpaqueQualType());
   m_value.SetCompilerType(m_compiler_type);
   lldb::addr_t load_address = m_address.GetLoadAddress(target_sp.get());
   if (load_address != LLDB_INVALID_ADDRESS) {
@@ -204,8 +202,6 @@ bool ValueObjectMemory::UpdateValue() {
         if (m_type_sp)
           value.SetContext(Value::eContextTypeLLDBType, m_type_sp.get());
         else {
-          // value.SetContext(Value::eContextTypeClangType,
-          // m_compiler_type.GetOpaqueQualType());
           value.SetCompilerType(m_compiler_type);
         }
 


        


More information about the lldb-commits mailing list