[Lldb-commits] [PATCH] D73808: [lldb/TypeSystemClang] Supply trivial TypeSourceInfo to NonTypeTemplateParmDecl::Create

Vedant Kumar via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Feb 4 13:46:41 PST 2020


vsk added a comment.

In D73808#1856503 <https://reviews.llvm.org/D73808#1856503>, @teemperor wrote:

> Thanks for looking into this. I didn't get around to fix that myself yet. Out of curiosity, how did you get this test to fail? When I apply just your changes to the test (without the TypeSystemClang changes) then the test still passed in my build with `LLVM_USE_SANITIZER:STRING=Address;Undefined` ?
>
> Otherwise this LGTM and is obviously better than just passing in a nullptr.


Hm, the modified test doesn't seem to trigger the sanitizer report. I expected it to but didn't verify: it looks like something more is needed to actually exercise the NonTypeTemplateParmDecl.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73808/new/

https://reviews.llvm.org/D73808





More information about the lldb-commits mailing list