[Lldb-commits] [PATCH] D73946: [lldb] Fix another instance where we pass a nullptr as TypeSourceInfo to NonTypeTemplateParmDecl::Create

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Feb 4 10:30:54 PST 2020


teemperor added a comment.

In D73946#1857244 <https://reviews.llvm.org/D73946#1857244>, @vsk wrote:

> We have test coverage for this already, not sure why the sanitizer bot hasn't flagged this already: http://lab.llvm.org:8080/coverage/coverage-reports/coverage/Users/buildslave/jenkins/workspace/coverage/llvm-project/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp.html#L1302


I think assigning a nullptr is fin as the constructor doesn't deference it. But I guess touching the decl in wrong way will cause Clang to touch the TypeSourceInfo?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73946/new/

https://reviews.llvm.org/D73946





More information about the lldb-commits mailing list