[Lldb-commits] [lldb] 88cd49e - [lldb] Increase LINK_INTERFACE_MULTIPLICITY for Debug builds

[Jan Kratochvil via lldb-commits]

Author: Jan Kratochvil
Date: 2020-02-04T14:30:27+01:00
New Revision: 88cd49e941b9a24ff9df4c1ed7b6f771b13b701e

URL: https://github.com/llvm/llvm-project/commit/88cd49e941b9a24ff9df4c1ed7b6f771b13b701e
DIFF: https://github.com/llvm/llvm-project/commit/88cd49e941b9a24ff9df4c1ed7b6f771b13b701e.diff

LOG: [lldb] Increase LINK_INTERFACE_MULTIPLICITY for Debug builds

On Fedora 30 x86_64 with
	cmake ../llvm-monorepo/llvm/ -DCMAKE_BUILD_TYPE=Debug  -DLLVM_USE_LINKER=gold -DLLVM_ENABLE_PROJECTS="lldb;clang;lld"  -DLLVM_USE_SPLIT_DWARF=ON -DCMAKE_C_COMPILER=clang  -DCMAKE_CXX_COMPILER=clang++ -DLLVM_ENABLE_ASSERTIONS=ON

It does not affect Release builds.

getting:
	lldb/source/Expression/IRInterpreter.cpp:1471: error: undefined reference to 'lldb_private::ThreadPlanCallFunctionUsingABI::ThreadPlanCallFunctionUsingABI(lldb_private::Thread&, lldb_private::Address const&, llvm::Type&, llvm::Type&, llvm::ArrayRef<lldb_private::ABI::CallArgument>, lldb_private::EvaluateExpressionOptions const&)'
	lldb/source/Expression/LLVMUserExpression.cpp:148: error: undefined reference to 'lldb_private::ThreadPlanCallUserExpression::ThreadPlanCallUserExpression(lldb_private::Thread&, lldb_private::Address&, llvm::ArrayRef<unsigned long>, lldb_private::EvaluateExpressionOptions const&, std::shared_ptr<lldb_private::UserExpression>&)'

Pavel Labath has suggest LINK_INTERFACE_MULTIPLICITY could be further
increased.

Differential Revision: https://reviews.llvm.org/D73847

Added: 
    

Modified: 
    lldb/source/Core/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/lldb/source/Core/CMakeLists.txt b/lldb/source/Core/CMakeLists.txt
index a03fe6f4800f..a4057d11077f 100644
--- a/lldb/source/Core/CMakeLists.txt
+++ b/lldb/source/Core/CMakeLists.txt
@@ -96,7 +96,7 @@ add_dependencies(lldbCore
 
 # Needed to properly resolve references in a debug build.
 # TODO: Remove once we have better layering
-set_target_properties(lldbCore PROPERTIES LINK_INTERFACE_MULTIPLICITY 4)
+set_target_properties(lldbCore PROPERTIES LINK_INTERFACE_MULTIPLICITY 5)
 
 if (LLDB_ENABLE_LIBEDIT)
   target_include_directories(lldbCore PRIVATE ${LibEdit_INCLUDE_DIRS})