[Lldb-commits] [PATCH] D73921: Assert that a subprogram should have a name when parsing DWARF

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:832
+  if (tag == DW_TAG_subprogram && !attrs.name) {
+    LLDB_LOGF(log, "Parsing a Subprogram that has no name");
+    assert(false && "Subprograms require a name");
----------------
aprantl wrote:
> The message should be:
> 
> "DWARF validation error: DW_TAG_subprogram without DW_AT_name"
> 
> Can you double-check that we don't already have an error reporting mechanism for malformed debug info?
Looks like other places use GetObjectFile()->GetModule()->ReportError() for this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73921/new/

https://reviews.llvm.org/D73921