[Lldb-commits] [PATCH] D73839: [LLDB] Add missing declarations for linking to psapi

Mon Feb 3 04:34:05 PST 2020

mstorsjo added a comment.

In D73839#1854333 <https://reviews.llvm.org/D73839#1854333>, @mstorsjo wrote:

> In D73839#1854328 <https://reviews.llvm.org/D73839#1854328>, @teemperor wrote:
>
> > I guess this is causing the windows failure on the bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/13320
>
>
> Yeah, I saw that - highly strange. I'll try to see if I can reproduce similar issues with a similar toolchain, and I'll push a revert soon unless I find some great clue.

The issue seems to have vanished in the following build, http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/13321, and I built a lldb-tblgen.exe using a fairly new version of MSVC, and that didn't seem to have the same issue ("This version of lldb-tblgen.exe is not compatible with the version of Windows you're running."). And the changes I pushed here shouldn't even affect the build of lldb-tblgen.exe at all. So I'd consider this just a coincidence/fluke for now.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73839/new/

https://reviews.llvm.org/D73839