[Lldb-commits] [PATCH] D73802: [lldb] Introduce i386 support in NetBSD Process plugin

[Kamil Rytarowski via Phabricator via lldb-commits]

krytarowski added inline comments.


================
Comment at: lldb/source/Plugins/Process/Utility/RegisterContextNetBSD_i386.cpp:62
+  GPR gpr;
+  FPR_i386 i387;
+  uint32_t u_debugreg[8]; // Debug registers (DR0 - DR7).
----------------
krytarowski wrote:
> mgorny wrote:
> > krytarowski wrote:
> > > mgorny wrote:
> > > > krytarowski wrote:
> > > > > Please add `uint32_t tlsbase;`.
> > > > To what purpose? It's not being used anywhere.
> > > Consistency with amd64 AND we will want to make use of it in future and present as a 'tlsbase' register or anything.
> > The only reason I didn't remove it from amd64 is because I don't believe it's worth the effort. I'm against proactively adding undocumented features, especially given how much time I've spent trying to figure out what those structures were doing. We can add it when we start using it.
> This was discussed when we were adding amd64 fields and it was decided to add tlsbase. Please add it here too.
Also there is now ptrace(2) API ready (`PT_LWPSTATUS`) to read tlsbase and I wish I saw its support in LLDB sooner than later.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73802/new/

https://reviews.llvm.org/D73802