[Lldb-commits] [PATCH] D73802: [lldb] Introduce i386 support in NetBSD Process plugin

[Kamil Rytarowski via Phabricator via lldb-commits]

krytarowski added inline comments.


================
Comment at: lldb/source/Plugins/Process/Utility/RegisterContextNetBSD_i386.cpp:62
+  GPR gpr;
+  FPR_i386 i387;
+  uint32_t u_debugreg[8]; // Debug registers (DR0 - DR7).
----------------
mgorny wrote:
> krytarowski wrote:
> > Please add `uint32_t tlsbase;`.
> To what purpose? It's not being used anywhere.
Consistency with amd64 AND we will want to make use of it in future and present as a 'tlsbase' register or anything.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73802/new/

https://reviews.llvm.org/D73802