[Lldb-commits] [PATCH] D73766: [RFC] Make substrs argument to self.expect ordered by default.

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

The current behavior does make tests less dependent on the exact details of lldb's command output.  If there were two independent pieces of data in a command output that you wanted to compare against, you would have to fix some tests if you ever changed the ordering in the result.  It was the case that the gdb test suite hampered the evolution of the command output because it was just too much of a pain to go change the tests.  For instance, you really couldn't muck with breakpoint reporting output or stop notifications; the pain of fixing up the testsuite was way too high.  But in this case, the fix would just be reordering the substrings in the Python array.  So though this sort of thing makes me a little uneasy, in this case I think it's fine.

Note, if there is a test that depends on the substring output not coming out in a fixed order, then I think giving that test the stink-eye is more appropriate than keeping an "ordered" flag around.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73766/new/

https://reviews.llvm.org/D73766