[Lldb-commits] [PATCH] D73787: [NFC] Refactor `GetDWARFDeclContext` to return `DWARFDeclContext`

Jan Kratochvil via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jan 31 08:10:10 PST 2020


jankratochvil created this revision.
jankratochvil added a reviewer: labath.
jankratochvil added a project: LLDB.
Herald added a subscriber: aprantl.
Herald added a reviewer: shafik.

In D70646 <https://reviews.llvm.org/D70646> I broke http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/7400/ so this is a second attempt.
Unfortunately I do not have reproducible the breakage of Green Dragon locally.
The bug was that `DWARFDebugInfoEntry::GetDWARFDeclContext` reversed order of the items, that is fixed now.
OK for check-in? It is no longer so pretty but still worth it IMO.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D73787

Files:
  lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
  lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp
  lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.h
  lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
  lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73787.241733.patch
Type: text/x-patch
Size: 5689 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200131/0325835d/attachment-0001.bin>


More information about the lldb-commits mailing list