[Lldb-commits] [PATCH] D73594: Refactor CommandObjectTargetSymbolsAdd::AddModuleSymbols

Fri Jan 31 00:46:16 PST 2020

labath accepted this revision.
labath added a comment.

In D73594#1851044 <https://reviews.llvm.org/D73594#1851044>, @clayborg wrote:

> Looks reasonable to me. Any objections from anyone else? We do have tests for this right?

LGTM too. There are tests for this command already, but of course, we could always use a bunch more, particularly for the "error" cases...

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73594/new/

https://reviews.llvm.org/D73594