[Lldb-commits] [PATCH] D73661: [lldb] Move clang-based files out of Symbol

Fri Jan 31 00:38:43 PST 2020

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

This looks good to me, and I believe everyone else also felt the same way. There are still some loops here (TypeSystemClang<->SymbolFileDWARF/PDB), but I think those could be broken fairly easily. This is not a problem of this patch, and it can be handled later..

================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:37

+#include "Plugins/ExpressionParser/Clang//ClangUtil.h"
+#include "Plugins/TypeSystem/Clang/TypeSystemClang.h"
----------------
remove one `/`

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73661/new/

https://reviews.llvm.org/D73661