[Lldb-commits] [PATCH] D73517: [lldb] Delete ValueObject::GetBaseClassPath

[Pavel Labath via Phabricator via lldb-commits]

labath added inline comments.


================
Comment at: lldb/source/Core/ValueObject.cpp:2041
 
 void ValueObject::GetExpressionPath(Stream &s, bool qualify_cxx_base_classes,
                                     GetExpressionPathFormat epformat) {
----------------
xiaobai wrote:
> labath wrote:
> > Should we remove the `qualify_cxx_base_classes` argument as well, given that it no longer does anything ?
> It seems that this is a part of the SBValue interface. I think we can remove it from ValueObject but SBValue will have to stick with it.
That sounds reasonable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73517/new/

https://reviews.llvm.org/D73517