[Lldb-commits] [PATCH] D73148: [lldb/Value] Avoid reading more data than the host has available

[Vedant Kumar via Phabricator via lldb-commits]

vsk updated this revision to Diff 241602.
vsk retitled this revision from "[lldb/Value] Report size of Value as size of underlying data buffer" to "[lldb/Value] Avoid reading more data than the host has available".
vsk edited the summary of this revision.
vsk added a comment.

Address review feedback:

- Add a test that doesn't depend on the compiler.
- Convert the old test into a simpler regression test.
- Based on feedback from Jim, don't try to change the definition of a Value's size, as the expectation that the type is correct is baked in deeply.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73148/new/

https://reviews.llvm.org/D73148

Files:
  lldb/packages/Python/lldbsuite/test/functionalities/optimized_code/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/optimized_code/TestNoASanExceptionAfterEvalOP_piece.py
  lldb/packages/Python/lldbsuite/test/functionalities/optimized_code/main.cpp
  lldb/source/Core/Value.cpp
  lldb/test/Shell/SymbolFile/DWARF/DW_OP_piece-smaller-than-struct.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73148.241602.patch
Type: text/x-patch
Size: 9152 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200130/4acd7be8/attachment.bin>