[Lldb-commits] [PATCH] D73665: Stop emitting a breakpoint for each location in a breakpoint when responding to breakpoint commands.

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jan 30 10:20:25 PST 2020

clayborg added a comment.

In D73665#1848755 <https://reviews.llvm.org/D73665#1848755>, @labath wrote:

> This is not ideal, but if that's what vscode wants, then I guess we just have to do it.
> However, are you sure that this is all that needs to be done here. It seems like also the handling of eBreakpointEventTypeLocationsAdded/Removed events in EventThreadFunction should be changed too. Otherwise, I think the whole breakpoint will disappear whenever a single location goes away...

That is the nice thing about this fix: anyone that reports a breakpoint uses:

  llvm::json::Value CreateBreakpoint(lldb::SBBreakpointLocation &bp_loc)

And this is the function I fixed!

  rG LLVM Github Monorepo



More information about the lldb-commits mailing list