[Lldb-commits] [PATCH] D72513: Don't fail step out if remote server doesn't implement qMemoryRegionInfo

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jan 28 11:46:47 PST 2020


jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.

I don't think you want to put anything in m_constructor_errors in this case either.  It's fine to log something out, but ValidatePlan uses m_constructor_errors to help report a problem.  If the breakpoint failed to take for some other reason, then we would report a permissions problem which is not the reason for the failure.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72513/new/

https://reviews.llvm.org/D72513





More information about the lldb-commits mailing list