[Lldb-commits] [PATCH] D73506: Auto-completion bug fix for dot operator

[Raphael Isemann via Phabricator via lldb-commits]

teemperor added a comment.

I don't really know the vscode plugin code but I pointed out when this was implemented <https://reviews.llvm.org/D69873#inline-629088> that the whole token replacement mechanism that LLDB's completion API uses is really hard to get right. If you're at it, you might also add some tests for the things I pointed out back then (e.g., `foo1. v` and `foo1 .v` and `foo1 . v`) where the returned tokens might be unexpectedly cut off.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73506/new/

https://reviews.llvm.org/D73506