[Lldb-commits] [PATCH] D73148: [lldb/Value] Report size of Value as size of underlying data buffer

Fri Jan 24 14:29:34 PST 2020

aprantl added a comment.

In D73148#1835488 <https://reviews.llvm.org/D73148#1835488>, @labath wrote:

> In D73148#1834955 <https://reviews.llvm.org/D73148#1834955>, @vsk wrote:
>
> > In D73148#1832897 <https://reviews.llvm.org/D73148#1832897>, @clayborg wrote:
> >
> > > Actually it would be nice to have a test that will trigger on at least one build bot that runs ASAN?
> >
> >
> > I'll add an end-to-end test for DW_OP_piece, though I worry it might be brittle.
>
>
> I don't think that's a good way to write a test like this. I suggest checking out `test/Shell/SymbolFile/DWARF/DW_OP_piece-struct.s` for an  dwarf expression test that does not rely on guessing the DW_OP opcodes used by the compiler. Maybe you can just take that test and tweak it to do what you need?

Sorry, I haven't read the rest yet, but for testing: Have you seen `lldb/unittests/Expression/DWARFExpressionTest.cpp` ?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73148/new/

https://reviews.llvm.org/D73148