[Lldb-commits] [PATCH] D72946: [lldb] Remove ClangASTImporter reference from Target

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jan 24 01:00:26 PST 2020


teemperor added inline comments.


================
Comment at: lldb/include/lldb/Symbol/TypeSystemClang.h:38
 
+#include "Plugins/ExpressionParser/Clang/ClangPersistentVariables.h"
+
----------------
I would also just let this be part of the normal include list without the empty line (or wherever clang format decides to place this).


================
Comment at: lldb/source/Plugins/Language/CPlusPlus/BlockPointer.cpp:21
 
+#include "Plugins/ExpressionParser/Clang/ClangPersistentVariables.h"
+
----------------
I would just keep this in the include list above and let clang-format do its thing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72946/new/

https://reviews.llvm.org/D72946





More information about the lldb-commits mailing list