[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Abort StackFrame Recognizer

[Med Ismail Bennani via Phabricator via lldb-commits]

mib marked an inline comment as done.
mib added inline comments.


================
Comment at: lldb/source/Target/AbortRecognizer.cpp:109
+
+  // FIXME: This breaks several tests.
+  //  m_stop_info_sp = StopInfo::CreateStopReasonForRecognizedFrame(
----------------
The tests failures happen because instead of returning a StopInfoUnixSignal for the abort, I changed it to StopInfoRecognizedFrame (inherited from StopInfoException) making the stop reason description not match with the previous tests.

Most of  those tests check the stop reason against the command interpreter output rather than using the SBAPI, so they'll probably need to be rewritten anyway.

I'm already working on a new way to handle this while causing the least amount of failures, but all suggestions are welcome.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73303/new/

https://reviews.llvm.org/D73303