[Lldb-commits] [PATCH] D70847: [lldb] Set executable module when adding modules to the Target
Greg Clayton via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Jan 21 12:24:06 PST 2020
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
context is missing with this diff (use git diff -U9999999). Changes look good. We do need a test though. All we need to do is create a target with nothing, then add the image to the target and make sure the platform and arch are updated. No need to run anything. Seeing as this wasn't working before this change, we don't have a test that covers it. You can create an ELF file and run obj2yaml on it and save the text file into the test directory. The test can run yaml2obj to generate the file, create an empty target, use the API that his patch fixes and very info on the target.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits