[Lldb-commits] [PATCH] D71770: [lldb] Don't process symlinks deep inside DWARFUnit

Tue Jan 21 12:23:33 PST 2020

aprantl added a comment.

Looks like this broke the ASAN bot?

http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-sanitized/783/testReport/junit/lldb-api/functionalities_breakpoint_comp_dir_symlink/TestCompDirSymLink_py/

lldb-api.functionalities/breakpoint/comp_dir_symlink.TestCompDirSymLink.py (from lldb-api):

  =================================================================
  ==83604==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000 (pc 0x7fff77668712 bp 0x7ffee0e29f10 sp 0x7ffee0e29f10 T0)
  ==83604==The signal is caused by a READ memory access.
  ==83604==Hint: address points to the zero page.
      #0 0x7fff77668712 in _platform_strlen+0x12 (libsystem_platform.dylib:x86_64+0x1712)
      #1 0x10ee1191b in wrap_readlink+0x5b (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x3991b)
      #2 0x119a61e57 in lldb_private::FileSystem::Readlink(lldb_private::FileSpec const&, lldb_private::FileSpec&) FileSystemPosix.cpp:46
      #3 0x1197f4b0d in lldb_private::ModuleListProperties::UpdateSymlinkMappings() ModuleList.cpp:122
      #4 0x119af5664 in lldb_private::OptionValueFileSpecList::SetValueFromString(llvm::StringRef, lldb_private::VarSetOperationType) OptionValueFileSpecList.cpp
      #5 0x119b01851 in lldb_private::OptionValueProperties::SetSubValue(lldb_private::ExecutionContext const*, lldb_private::VarSetOperationType, llvm::StringRef, llvm::StringRef) OptionValueProperties.cpp:209
      #6 0x119886a80 in lldb_private::Properties::SetPropertyValue(lldb_private::ExecutionContext const*, lldb_private::VarSetOperationType, llvm::StringRef, llvm::StringRef) UserSettingsController.cpp:49
      #7 0x1197234cb in lldb_private::Debugger::SetPropertyValue(lldb_private::ExecutionContext const*, lldb_private::VarSetOperationType, llvm::StringRef, llvm::StringRef) Debugger.cpp:275
      #8 0x11c2e19ef in CommandObjectSettingsSet::DoExecute(llvm::StringRef, lldb_private::CommandReturnObject&) CommandObjectSettings.cpp:222
      #9 0x119aba342 in lldb_private::CommandObjectRaw::Execute(char const*, lldb_private::CommandReturnObject&) CommandObject.cpp:1003
      #10 0x119a94b4a in lldb_private::CommandInterpreter::HandleCommand(char const*, lldb_private::LazyBool, lldb_private::CommandReturnObject&, lldb_private::ExecutionContext*, bool, bool) CommandInterpreter.cpp:1762
      #11 0x118c1b547 in lldb::SBCommandInterpreter::HandleCommand(char const*, lldb::SBExecutionContext&, lldb::SBCommandReturnObject&, bool) SBCommandInterpreter.cpp:281
      #12 0x118c1a83a in lldb::SBCommandInterpreter::HandleCommand(char const*, lldb::SBCommandReturnObject&, bool) SBCommandInterpreter.cpp:259
      #13 0x1193cfa28 in _wrap_SBCommandInterpreter_HandleCommand(_object*, _object*) LLDBWrapPython.cpp:14074

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71770/new/

https://reviews.llvm.org/D71770