[Lldb-commits] [PATCH] D73116: [lldb/Initializers] Move all macOS initializers into PlatformMacOSX

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jan 21 09:23:01 PST 2020


labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

this seems fine to me.



================
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp:9-35
 #include "PlatformMacOSX.h"
 #include "lldb/Host/Config.h"
-
-
-#include <sstream>
+#include "PlatformiOSSimulator.h"
+#include "PlatformDarwinKernel.h"
+#include "PlatformAppleTVSimulator.h"
+#include "PlatformAppleWatchSimulator.h"
+#include "PlatformRemoteAppleTV.h"
----------------
The placement of all of this is still pretty odd (the Host/Config.h seems weirdly sandwiched between macos files). Just delete the whitespace and let clang-format sort things?


================
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp:71-77
+  PlatformRemoteAppleBridge::Initialize();
+  PlatformRemoteAppleWatch::Initialize();
+  PlatformRemoteAppleTV::Initialize();
+  PlatformAppleWatchSimulator::Initialize();
+  PlatformAppleTVSimulator::Initialize();
+  PlatformDarwinKernel::Initialize();
+  PlatformiOSSimulator::Initialize();
----------------
terminate


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73116/new/

https://reviews.llvm.org/D73116





More information about the lldb-commits mailing list