[Lldb-commits] [PATCH] D73018: [lldb] Add SystemInitializerAllPlugins and delete copy-pasted Init code in SystemInitializerFull and SystemInitializerTest

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jan 21 01:35:41 PST 2020

teemperor marked an inline comment as done.
teemperor added a comment.

I moved the single non-plugin call back to the original Full/Test subclasses so the name is now correct. Also I removed all the duplicated linking flags that I forgot to remove before.

I also don't think we should make this a header. With a header we still need to copy the linking flags around and it also deviates from the existing approach of using subclasses like SystemInitializerCommon (which anyway looks nicer).



More information about the lldb-commits mailing list