[Lldb-commits] [PATCH] D72909: Make SymbolFileDWARF::ParseLineTable use std::sort instead of insertion sort
Raphael Isemann via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Jan 21 01:35:38 PST 2020
teemperor added inline comments.
================
Comment at: lldb/source/Symbol/LineTable.cpp:27
+ LineTable::Entry::LessThanBinaryPredicate less_than_bp(this);
+ std::sort(sequences.begin(), sequences.end(), less_than_bp);
+ for (auto *sequence : sequences) {
----------------
grimar wrote:
> I wonder if this have to be `std::stable_sort`?
> For `std::sort` the order of equal elements is not guaranteed to be preserved.
>
> nit: you could also probably use the `llvm::sort` (it would be a bit shorter):
> `llvm::sort(sequences, less_than_bp);`
I think we should change this to llvm::sort just because of the additional checks we get there (I think the shuffle/sort<->stable_sort checks are only in llvm::sort).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72909/new/
https://reviews.llvm.org/D72909
More information about the lldb-commits
mailing list