[Lldb-commits] [PATCH] D73067: [lldb/CMake] Auto-generate the Initialize and Terminate calls for plugins
Jonas Devlieghere via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Jan 20 16:09:24 PST 2020
JDevlieghere marked an inline comment as done.
JDevlieghere added inline comments.
================
Comment at: lldb/source/API/SystemInitializerFull.cpp:136
+// Some of the plugins have their own namespace.
+using namespace lldb_private::breakpad;
+using namespace clang;
----------------
I used the namespaces to limit the churn, but I would prefer to just remove them altogether form the plugins, or at least have the main entry point live under `lldb_private`.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73067/new/
https://reviews.llvm.org/D73067
More information about the lldb-commits
mailing list