[Lldb-commits] [PATCH] D72920: [lldb/DWARF] Simplify DWARFDebugInfoEntry::LookupAddress

Mon Jan 20 03:39:54 PST 2020

labath added a comment.

In D72920#1827480 <https://reviews.llvm.org/D72920#1827480>, @clayborg wrote:

> LGTM. Much cleaner using the newer DWARFDIE code. Not sure if we can unit test this?

"image lookup --address" is sufficiently low level to be considered a unit test. We already have test using it (though we could always have more), and a lot of other integration tests fail if this goes wrong due to not being able to find local variables.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72920/new/

https://reviews.llvm.org/D72920