[Lldb-commits] [PATCH] D72909: Make SymbolFileDWARF::ParseLineTable use std::sort instead of insertion sort
Raphael Isemann via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Jan 17 03:48:30 PST 2020
teemperor added inline comments.
================
Comment at: lldb/source/Symbol/LineTable.cpp:172
+ LineSequenceImpl *seq_b = reinterpret_cast<LineSequenceImpl *>(sequence_b);
+ return (*this)(seq_a->m_entries.front(), seq_b->m_entries.front());
+}
----------------
Nit pick, this would also work without the `reinterpret_cast` and const arguments. E.g.:
```
lang=c++
bool LineTable::Entry::LessThanBinaryPredicate::
operator()(const LineSequence *sequence_a, const LineSequence *sequence_b) const {
auto *seq_a = static_cast<const LineSequenceImpl *>(sequence_a);
auto *seq_b = static_cast<const LineSequenceImpl *>(sequence_b);
return (*this)(seq_a->m_entries.front(), seq_b->m_entries.front());
}
```
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72909/new/
https://reviews.llvm.org/D72909
More information about the lldb-commits
mailing list