[Lldb-commits] [PATCH] D72813: Fixes to lldb's eLaunchFlagLaunchInTTY feature on macOS

Thu Jan 16 13:36:09 PST 2020

jasonmolenda added a comment.

In D72813#1825006 <https://reviews.llvm.org/D72813#1825006>, @clayborg wrote:

> ok if this works for now that is fine. Just close the socket_fd when we fail to write the pid to the socket and this is good to go.

I mark it as close-on-exec so we don't need to close it explicitly (I was going to try to detect the closing of the socket up in lldb to get us closer to the new process being launched, but the existing Read method doesn't detect it)

I'm looking at whether we can special case the "darwin-debug execs a process, and that process is started suspended" handling in debugserver/lldb.  If we attach while darwin-debug is executing, then we get the exec mach exception, and the inferior has a suspend count of two -- one, because we stopped for the mach exception we just got, but a second suspend because darwin-debug asked for the inferior to be started suspended.  We need that second suspend count if we don't attach until after the inferior has been started.  So I might toss this entire approach; working on this some more.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72813/new/

https://reviews.llvm.org/D72813