[Lldb-commits] [PATCH] D71770: [lldb] Don't process symlinks deep inside DWARFUnit
Jonas Devlieghere via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Jan 13 11:22:18 PST 2020
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: lldb/include/lldb/Core/Module.h:972
+ ModuleList::GetGlobalModuleListProperties()
+ .GetSymlinkMappings(); ///< Module specific source remappings for
+ /// when you have debug info for a module
----------------
Nit: can you move the comment before the variable with `///`? `///<` rarely makes sense with the 80 col limit and it's already broken in the comment for `m_old_symfiles`...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71770/new/
https://reviews.llvm.org/D71770
More information about the lldb-commits
mailing list