[Lldb-commits] [PATCH] D63540: Fix lookup of symbols with the same address range but different binding
Jan Kratochvil via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Jan 13 03:09:46 PST 2020
jankratochvil marked 2 inline comments as done.
jankratochvil added inline comments.
================
Comment at: lldb/include/lldb/Symbol/Symtab.h:159-161
+ else if (symbol.IsWeak())
+ return 2;
+ else if (symbol.IsDebug())
----------------
labath wrote:
> [[ http://llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return | Don’t use else after a return ]]
Thanks for catching it. It is a leftover from `val = X` of [[ https://reviews.llvm.org/D63540?id=234672 | previous version of the patch ]].
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63540/new/
https://reviews.llvm.org/D63540
More information about the lldb-commits
mailing list