[Lldb-commits] [lldb] d3ba1e0 - [lldb/Reproducer] Add SBReproducer::Replay overload (again)

[Jonas Devlieghere via lldb-commits]

Author: Jonas Devlieghere
Date: 2020-01-10T15:02:21-08:00
New Revision: d3ba1e026dbc44e9097ce6ea1c92d065f1fe33e8

URL: https://github.com/llvm/llvm-project/commit/d3ba1e026dbc44e9097ce6ea1c92d065f1fe33e8
DIFF: https://github.com/llvm/llvm-project/commit/d3ba1e026dbc44e9097ce6ea1c92d065f1fe33e8.diff

LOG: [lldb/Reproducer] Add SBReproducer::Replay overload (again)

I modified the SBAPI under the assumption that nobody was using the old
API yet. However, that turns out to be false. So instead of adding the
deafault argument I've reintroduced the old API and made the new one an
overload.

Added: 
    

Modified: 
    lldb/include/lldb/API/SBReproducer.h
    lldb/source/API/SBReproducer.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/include/lldb/API/SBReproducer.h b/lldb/include/lldb/API/SBReproducer.h
index 8bb530a0fe42..93d78f55fd76 100644
--- a/lldb/include/lldb/API/SBReproducer.h
+++ b/lldb/include/lldb/API/SBReproducer.h
@@ -20,7 +20,8 @@ class LLDB_API SBReproducer {
 public:
   static const char *Capture();
   static const char *Capture(const char *path);
-  static const char *Replay(const char *path, bool skip_version_check = false);
+  static const char *Replay(const char *path);
+  static const char *Replay(const char *path, bool skip_version_check);
   static const char *GetPath();
   static bool Generate();
 };

diff  --git a/lldb/source/API/SBReproducer.cpp b/lldb/source/API/SBReproducer.cpp
index 1107161a419f..3d2de0727444 100644
--- a/lldb/source/API/SBReproducer.cpp
+++ b/lldb/source/API/SBReproducer.cpp
@@ -124,6 +124,10 @@ const char *SBReproducer::Capture(const char *path) {
   return nullptr;
 }
 
+const char *SBReproducer::Replay(const char *path) {
+  return SBReproducer::Replay(path, false);
+}
+
 const char *SBReproducer::Replay(const char *path, bool skip_version_check) {
   static std::string error;
   if (auto e = Reproducer::Initialize(ReproducerMode::Replay, FileSpec(path))) {