[Lldb-commits] [PATCH] D70846: Expression eval lookup speedup by not returning methods in ManualDWARFIndex::GetFunctions

Shafik Yaghmour via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jan 9 09:17:52 PST 2020


shafik added a comment.

In D70846#1809837 <https://reviews.llvm.org/D70846#1809837>, @labath wrote:

> This looks fine to me. @shafik, @teemperor, do you have any more comments?


Just a minor comment.



================
Comment at: lldb/test/Shell/SymbolFile/DWARF/find-basic-function.cpp:67
+
+// FULL: Found 0 functions:
 
----------------
You don't actually run a `FULL` test, is this purposeful? 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70846/new/

https://reviews.llvm.org/D70846





More information about the lldb-commits mailing list